Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-4844: Update precompile address for 4844 #7172

Merged
merged 3 commits into from
Jun 22, 2023

Conversation

ralexstokes
Copy link
Member

It looks like the next available precompile address is 0xA so let's use this one in 4844

(cf https://github.com/ethereum/execution-specs/blob/master/src/ethereum/shanghai/vm/precompiled_contracts/__init__.py#L38 )

Use the next available precompile at the time of deployment
@ralexstokes ralexstokes marked this pull request as ready for review June 12, 2023 22:41
@ralexstokes ralexstokes requested a review from eth-bot as a code owner June 12, 2023 22:41
@github-actions github-actions bot added c-update Modifies an existing proposal s-review This EIP is in Review t-core labels Jun 12, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Jun 12, 2023

✅ All reviewers have approved.

@eth-bot eth-bot changed the title Update precompile address for 4844 Update EIP-4844: Update precompile address for 4844 Jun 12, 2023
@eth-bot eth-bot added the a-review Waiting on author to review label Jun 12, 2023
@Kowtko21
Copy link

$nicholaskowtko

Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, discussed on ACD 164 and everyone was okay with making this change

@eth-bot eth-bot enabled auto-merge (squash) June 22, 2023 14:27
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-review Waiting on author to review c-update Modifies an existing proposal s-review This EIP is in Review t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants